Cleans up the JIT block viewer in the WX UI. #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
JitBlockView-cleanup
branch
from
bcfd45c
to
315401d
Compare
| std::string HostDisassemblerX86::DisassembleHostBlock(const u8* code_start, const u32 code_size, u32 *host_instructions_count) | ||
| { | ||
| u64 disasmPtr = (u64)code_start; | ||
| const u8 *end = code_start + code_size; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
force-pushed
the
JitBlockView-cleanup
branch
from
315401d
to
a9d41f7
Compare
This code was an absolute mess. It had allocated an arbitrarily large string buffer to hold instructions that were disassembled. Strip out all of the nasty raw C string manipulation and replaces it with ostringstream usage. Fixes an issue where if you didn't have a JIT recompiler running then Dolphin would instantly crash if you tried comparing PPC to x86 code. Changed the disassembly of the host side code from being inline to the function to instead being in a class, this will be required when I add support for ARMv7 and AArch64 to this window.
Sonicadvance1
force-pushed
the
JitBlockView-cleanup
branch
from
a9d41f7
to
ecf65d6
Compare
skidau
added a commit
that referenced
this pull request
Oct 24, 2014
Cleans up the JIT block viewer in the WX UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was an absolute mess. It had allocated an arbitrarily large string buffer to hold instructions that were disassembled.
Strip out all of the nasty raw C string manipulation and replaces it with ostringstream usage.
Fixes an issue where if you didn't have a JIT recompiler running then Dolphin would instantly crash if you tried comparing PPC to x86 code.
Changed the disassembly of the host side code from being inline to the function to instead being in a class, this will be required when I add support
for ARMv7 and AArch64 to this window.