Implements LLVM based disassembler for the debugger. #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
LLVM-disasm
branch
3 times, most recently
from
195f9f7
to
7f060ee
Compare
| // Once that conflict is resolved this can be moved to the header | ||
| class HostDisassemblerLLVM : public HostDisassembler | ||
| { | ||
| public: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
force-pushed
the
LLVM-disasm
branch
from
7f060ee
to
356a14c
Compare
| if (LLVM_DIR) | ||
| add_definitions(-DHAS_LLVM=1) | ||
| set(HAS_LLVM 1) | ||
| find_package(LLVM REQUIRED CONFIG) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
force-pushed
the
LLVM-disasm
branch
from
356a14c
to
a773fb9
Compare
This will work for all of our platforms, x86, ARMv7, and AArch64. Main issue with this is that LLVM's cmake files aren't correctly finding the LLVM install. Not sure if this is Ubuntu's issue or not, it may just work on other operating systems. We could potentially improve this, you can pass in a specific CPU in to the LLVM disassembler. This would probably affect latency times that are reported by LLVM's disassembly? This needs to be further investigated later.
Sonicadvance1
changed the title
Sonicadvance1
force-pushed
the
LLVM-disasm
branch
from
a773fb9
to
cb10bef
Compare
skidau
added a commit
that referenced
this pull request
Oct 26, 2014
Implements LLVM based disassembler for the debugger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work for all of our platforms, x86, ARMv7, and AArch64.
Main issue with this is that LLVM's cmake files aren't correctly finding the LLVM install.
Not sure if this is Ubuntu's issue or not, it may just work on other operating systems.
We could potentially improve this, you can pass in a specific CPU in to the LLVM disassembler. This would probably affect latency times that are
reported by LLVM's disassembly? This needs to be further investigated later.