VideoCommon{Backends}: Remove unnecessary wxWidgets references. #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
dammit-wxwidgeeeeeets
branch
from
c61422f
to
acadeb5
Compare
lioncash
changed the title
|
All good to merge now |
|
@dolphin-emu-bot rebuild |
lioncash
force-pushed
the
dammit-wxwidgeeeeeets
branch
from
acadeb5
to
6490780
Compare
lioncash
changed the title
lioncash
force-pushed
the
dammit-wxwidgeeeeeets
branch
3 times, most recently
from
a4131fe
to
23ca707
Compare
EmuWindow doesn't even exist anymore. wxWidgets is also decoupled from the backends.
lioncash
force-pushed
the
dammit-wxwidgeeeeeets
branch
from
23ca707
to
9ab9245
Compare
|
<3 u. |
lioncash
added a commit
that referenced
this pull request
Nov 2, 2014
VideoCommon{Backends}: Remove unnecessary wxWidgets references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also EmuWindow doesn't even exist anymore.
Turns out InputCommon actually relied on wx linking in the correct OSX libraries, so it removes even more coupling in that regard.
Now building VideoCommon and the Software and OGL backends isn't blocked by the compilation of wx (at least on OSX. *nix just ignores building the static version if wx is already installed on the system).