Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indentation in PR 1450. #1458

Merged
merged 1 commit into from Nov 1, 2014
Merged

Conversation

phire
Copy link
Member

@phire phire commented Nov 1, 2014

Would have been nice if this was caught a few min earlier.

Would have been nice if this was caught a few min earlier.
@Buddybenj
Copy link
Contributor

@skidau says whitespace changes should also come with functional changes, however I disagree and think it should be allowed, so +1 from me.

@phire
Copy link
Member Author

phire commented Nov 1, 2014

I really don't like the idea of merging a whitespace fix into a mostly
unrelated PR.


Scott Mansell

On 1 November 2014 15:50, Buddybenj notifications@github.com wrote:

@skidau https://github.com/skidau says whitespace changes should also
come with functional changes, however I disagree and think it should be
allowed, so +1 from me.


Reply to this email directly or view it on GitHub
#1458 (comment).

@phire
Copy link
Member Author

phire commented Nov 1, 2014

@dolphin-emu-bot rebuild

lioncash added a commit that referenced this pull request Nov 1, 2014
Fix Indentation in PR 1450.
@lioncash lioncash merged commit c83dc2a into dolphin-emu:master Nov 1, 2014
@phire phire deleted the fix1450Tabs branch July 4, 2015 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants