Remove some gotos. #1486
Merged
Remove some gotos. #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (finalise) | ||
| { | ||
| if (info_ptr != nullptr) png_free_data(png_ptr, info_ptr, PNG_FREE_ALL, -1); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
What's wrong with the gotos? I think the code is clearer and better with them. |
| @@ -322,7 +322,7 @@ bool Copy(const std::string &srcFilename, const std::string &destFilename) | |||
| char buffer[BSIZE]; | |||
|
|
|||
| // Open input file | |||
| FILE *input = fopen(srcFilename.c_str(), "rb"); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@magcius Maybe the VideoCommon commit complicates the code too much, but I think the FileUtil changes are good. |
| } | ||
| } | ||
|
|
||
| // write output | ||
| int wnum = fwrite(buffer, sizeof(char), rnum, output); | ||
| int wnum = fwrite(buffer, sizeof(char), rnum, output.GetHandle()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@dolphin-emu-bot rebuild |
|
lgtm, if you remove the VideoCommon commit. @dolphin-emu-bot rebuild |
|
Update on this PR ?? |
|
@dolphin-emu-bot rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.