Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy OpenMP #1510

Merged
merged 1 commit into from Nov 7, 2014
Merged

Destroy OpenMP #1510

merged 1 commit into from Nov 7, 2014

Conversation

magcius
Copy link
Member

@magcius magcius commented Nov 7, 2014

No description provided.

@waddlesplash
Copy link
Contributor

Performance difference?

@magcius
Copy link
Member Author

magcius commented Nov 7, 2014

Untested.

@magcius
Copy link
Member Author

magcius commented Nov 7, 2014

Sanity difference: 10.

lioncash added a commit that referenced this pull request Nov 7, 2014
@lioncash lioncash merged commit fabfe14 into dolphin-emu:master Nov 7, 2014
@Icekhaos
Copy link

Icekhaos commented Nov 7, 2014

Why was this done?

@JMC47
Copy link
Contributor

JMC47 commented Nov 7, 2014

It was glitchy and slower than regular options. NVIDIA users were completely broken by it.

@magcius magcius deleted the destroy-openmp branch November 7, 2014 06:31
@degasus
Copy link
Member

degasus commented Nov 7, 2014

Sorry, I don't see how this could break NVIDIA. This shouldn't affect the video backend at all ...

@Icekhaos
Copy link

Icekhaos commented Nov 7, 2014

I've used an NVIDIA with OpenMP enabled in pretty much everything I've waded through, and I've had absolutely no breakage. Where was this breakage? Was it actually slower, unlike the option stated?

@JMC47
Copy link
Contributor

JMC47 commented Nov 7, 2014

There's a setting in NVIDIA's drivers that (iirc) were defaulted at some point that made OpenGL + OpenMP incredibly slow. Overall, OpenMP is slower even without the glitches anyway, which is why it needed to be removed.

@Icekhaos
Copy link

Icekhaos commented Nov 7, 2014

Never had a default that did that. What were its advantages, and how were they dispelled?

@magcius
Copy link
Member Author

magcius commented Nov 7, 2014

OpenMP has never been fast or good from my understanding

@MayImilae
Copy link
Contributor

A full explanation will be in the next progress report.

@Kingdude
Copy link

Kingdude commented Nov 7, 2014

OpenMP was supposed to add a performance boost for computers with more than two processor cores.

@JMC47
Copy link
Contributor

JMC47 commented Nov 7, 2014

It was supposed to; that doesn't mean it did.

@Icekhaos
Copy link

Icekhaos commented Nov 7, 2014

Alright, that works for me. I guess the builtin thing got optimized to the curb hard enough by Fiora to make it unnessecary?

@Kingdude
Copy link

It would be nice to see something that can take advantage of more than
three cores. Hmm what if there was a feature that could use a fourth core
as an extra graphics pre-processor? You know, for those mods that overhaul
graphics so much that it could be necessary for another core.

On Fri, Nov 7, 2014 at 12:50 PM, Icekhaos notifications@github.com wrote:

Alright, that works for me. I guess the builtin thing got optimized to the
curb hard enough by Fiora to make it unnessecary?


Reply to this email directly or view it on GitHub
#1510 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants