Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS X Requirement to 10.9 #1533

Closed
wants to merge 2 commits into from
Closed

Update OS X Requirement to 10.9 #1533

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2014

Update OS X requirement to 10.9 as per https://code.google.com/p/dolphin-emu/issues/detail?id=7243

@pauldacheez
Copy link
Contributor

Dolphin still runs on 10.7/10.8 fine as long as you have a GL3 GPU. That said, it does have enough issues on 10.7/10.8 that I'd prefer the requirement be upped.

If you're gonna up the requirement, change it in CMakeLists.txt too, please. (If you want to keep the branch as a single commit, do git commit --amend after git add-ing your changes.)

@Fuzzik
Copy link

Fuzzik commented Nov 12, 2014

Would it be a good idea to require 10.7+, but maybe add something that says 10.9 is recommended?

@pauldacheez
Copy link
Contributor

Every Mac (that I know of) that can run current Dolphin at all (e.g. meets the GPU requirements) is upgradeable all the way to 10.10 Yosemite, and 10.9 Mavericks had major OpenGL runtime/driver improvements (full GL 3.3 support for all GPUs, full GL 4.1 for newer GPUs). 10.7 Lion has issues with GL support in most cases, and 10.8 Mountain Lion isn't even well-tested enough for me to know of any issues; even if we can technically support 10.7/10.8 on certain GPUs, I'd rather avoid any corner cases and require Mavericks so that it either runs fine or just tells you to upgrade.

@Fuzzik
Copy link

Fuzzik commented Nov 12, 2014

Sounds like a good idea.

@ghost
Copy link
Author

ghost commented Nov 13, 2014

Okay CMakeLists.txt should be updated now too. Bear with me if I'm doing anything wrong as I'm fairly new to working with GitHub.

@ghost ghost changed the title Update OS X Requirement in Readme.md Update OS X Requirement to 10.9 Nov 13, 2014
@comex
Copy link
Contributor

comex commented Nov 14, 2014

LGTM
@dolphin-emu-bot rebuild

@comex
Copy link
Contributor

comex commented Nov 14, 2014

@pringo Build failure - for some reason this PR causes <objc/objc.h> to get included in the same file as SoundTouch. Yay C

@ghost
Copy link
Author

ghost commented Nov 14, 2014

Is that a problem I can fix on my end?

@comex
Copy link
Contributor

comex commented Nov 15, 2014

Do you know C++? If not, I can figure it out...

@ghost
Copy link
Author

ghost commented Nov 15, 2014

I do not.

@comex comex closed this Nov 16, 2014
@ghost ghost deleted the patch-1 branch December 5, 2014 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants