New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OS X Requirement to 10.9 + fixes #1561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't actually tested the power assertion thing because I don't have a Wiimote. Anyone on OS X want to do that..? |
@comex please adjust DolphinQt accordingly (Main.cpp & SystemInfo.cpp) [and WX too if it needs it]. |
Update OS X requirement to 10.9 as per https://code.google.com/p/dolphin-emu/issues/detail?id=7243
Also, this avoids keeping the system awake if a game is not being played. Frankly, I don't know what the point of precisely tracking these things is, but that's how the API works. Feel free to add analogous functionality on other platforms.
weird that such a simple change doesn't seem to have any obvious documentation on Apple's website or elsewhere...
Please review. |
LGTM |
I'll check this with real Wii Remotes later today or tomorrow if possible. Feel free to ping me repeatedly tomorrow about it. |
LGTM |
skidau
added a commit
that referenced
this pull request
Nov 26, 2014
Update OS X Requirement to 10.9 + fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1533, but adds some fixes for new issues that come up when compiling with -mmacosx-version-min=10.9.