Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS X Requirement to 10.9 + fixes #1561

Merged
merged 6 commits into from Nov 26, 2014
Merged

Conversation

comex
Copy link
Contributor

@comex comex commented Nov 16, 2014

Based on #1533, but adds some fixes for new issues that come up when compiling with -mmacosx-version-min=10.9.

@comex
Copy link
Contributor Author

comex commented Nov 16, 2014

I haven't actually tested the power assertion thing because I don't have a Wiimote. Anyone on OS X want to do that..?

@waddlesplash
Copy link
Contributor

@comex please adjust DolphinQt accordingly (Main.cpp & SystemInfo.cpp) [and WX too if it needs it].

pringo and others added 5 commits November 25, 2014 00:27
Also, this avoids keeping the system awake if a game is not being
played.

Frankly, I don't know what the point of precisely tracking these things
is, but that's how the API works.  Feel free to add analogous
functionality on other platforms.
weird that such a simple change doesn't seem to have any obvious
documentation on Apple's website or elsewhere...
@comex
Copy link
Contributor Author

comex commented Nov 25, 2014

Please review.

@waddlesplash
Copy link
Contributor

LGTM

@pauldacheez
Copy link
Contributor

I'll check this with real Wii Remotes later today or tomorrow if possible. Feel free to ping me repeatedly tomorrow about it.

@Parlane
Copy link
Member

Parlane commented Nov 25, 2014

LGTM

skidau added a commit that referenced this pull request Nov 26, 2014
Update OS X Requirement to 10.9 + fixes
@skidau skidau merged commit 69bd156 into dolphin-emu:master Nov 26, 2014
@comex comex deleted the 10.9 branch November 26, 2014 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants