New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the controller configuration dialogs. #1587
Conversation
I like it. Also, maybe background input should be moved here. |
Disable all controller selections if movie or netplay is active. |
Nice! I like it. |
I always thought how the controls were separate was kind of cumbersome. I'm a big fan of moving them together! |
That dialog is a bit tall... maybe make it have 2 columns? |
2 columns would leave a huge gap below it, making it even more unseemly (I had tried this approach initially) |
Okay, 3 columns (1 GC / 2 Wii) EDIT: if that fails, use a horizontal scrollbar and 6 columns!! 😆 |
BIKESHEDDING TIIIIIIIIIIIIME |
Beginning of unifying the controller settings. No functionality yet.
… movie is active.
Unify the controller configuration dialogs.
Protip: Alt+Printscreen. |
Is there any reason to keep the wiimote.png and gcpad.png images after this? |
Possibly, for either fallbacks or oddball cases. You can consider them unused until further notice for now. |
Prior to this, the configuration for the GameCube controller port devices were in the Config->Gamecube menu, whereas the Wiimotes had their own menu. This unifies the ports into the same dialog. Here is how it looks:
I made this PR to begin discussion and hear opinions on whether or not this is a good idea. This UI can be changed in the future to accommodate suggestions in another PR as the goal of this pull request was to join all of the controller menu logic into one central area.
If this is seen as a good idea, then a new icon will need to be made, as a picture of a Wiimote+Nunchuk wouldn't visually describe the unified menu accurately.