Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the controller configuration dialogs. #1587

Merged
merged 11 commits into from Dec 1, 2014

Conversation

lioncash
Copy link
Member

Prior to this, the configuration for the GameCube controller port devices were in the Config->Gamecube menu, whereas the Wiimotes had their own menu. This unifies the ports into the same dialog. Here is how it looks:
Imgur

I made this PR to begin discussion and hear opinions on whether or not this is a good idea. This UI can be changed in the future to accommodate suggestions in another PR as the goal of this pull request was to join all of the controller menu logic into one central area.

If this is seen as a good idea, then a new icon will need to be made, as a picture of a Wiimote+Nunchuk wouldn't visually describe the unified menu accurately.

@RachelBryk
Copy link
Member

I like it. Also, maybe background input should be moved here.

@RachelBryk
Copy link
Member

Disable all controller selections if movie or netplay is active.

@MayImilae
Copy link
Contributor

As for an icon for a unified controller configuration, I was thinking of using the classic controller pro icon that I use in my forum signature.

Classic Controller Pro

It's a vaguely generic controller, yet it's still Nintendo and related to what Dolphin is emulating. And it's my favorite controller! :D

@lioncash
Copy link
Member Author

Nice! I like it.

@cammelspit
Copy link

I always thought how the controls were separate was kind of cumbersome. I'm a big fan of moving them together!

@waddlesplash
Copy link
Contributor

That dialog is a bit tall... maybe make it have 2 columns?

@lioncash
Copy link
Member Author

2 columns would leave a huge gap below it, making it even more unseemly (I had tried this approach initially)

@waddlesplash
Copy link
Contributor

Okay, 3 columns (1 GC / 2 Wii)

EDIT: if that fails, use a horizontal scrollbar and 6 columns!! 😆

@pauldacheez
Copy link
Contributor

BIKESHEDDING TIIIIIIIIIIIIME

@lioncash lioncash changed the title [RFC] Unify the controller configuration dialogs. Unify the controller configuration dialogs. Dec 1, 2014
lioncash added a commit that referenced this pull request Dec 1, 2014
Unify the controller configuration dialogs.
@lioncash lioncash merged commit 3210a94 into dolphin-emu:master Dec 1, 2014
@lioncash lioncash deleted the input-move branch December 1, 2014 09:19
@Icekhaos
Copy link

Icekhaos commented Dec 3, 2014

Protip: Alt+Printscreen.

@Buddybenj
Copy link
Contributor

Is there any reason to keep the wiimote.png and gcpad.png images after this?

@Icekhaos
Copy link

Icekhaos commented Dec 8, 2014

Possibly, for either fallbacks or oddball cases. You can consider them unused until further notice for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants