New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiimoteReal: use inheritance instead of #ifdef #1596
Conversation
Probably easiest/nicest to have an |
Shouldn't |
Or maybe that would be overkill. Just casting should be fine, really, but the members should have Other people might say that there should be a getter, but they should die in a fire. |
Addressed comments. |
@@ -26,8 +26,7 @@ class Wiimote : NonCopyable | |||
{ | |||
friend class WiimoteEmu::Wiimote; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LGTM but the osx part. I have no clue what we're doing there :D |
@comex Haters gonna hate. What's so bad about getters? |
class WiimoteWindows : public Wiimote | ||
{ | ||
public: | ||
WiimoteWindows(std::basic_string<TCHAR> path); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
9955d97
to
74add95
Compare
Rebased. Derived destructors need to call |
Split into separate commits. This should make reviewing much easier. |
WiimoteReal: use inheritance instead of #ifdef
After this update (4508) wii modes does not work correctly on the MacOsX (10.9.5). If you connect 1 Wiimode it works flawlessly, if you add another Wiimode, Wiimode 1 Freezes, Wiimode 2 Works. If you disconnect Wiimode 2, Wiimode 1 will unfreeze. Can you undo this update? Dolphin 4508 and up now only work with one Wiimode, Dolphin 4503 and below all work with 2 or more Wiimode. On MacOsX Yosemite (10.10.x) Wiimodes no longer work for any version, so don't update to MacOsX 10.10 until this is resolved. |
Please file a bug in the issue tracker (http://code.google.com/p/dolphin-emu/issues/list); comments on already-merged PRs are not a good way to track issues. |
The OS X implementation doesn't compile yet. Could someone familiar with Objective C please help me find a good way to solve this, @comex maybe? My primitive solution would be making the class variables public and casting the objects from the
g_wiimotes
list toWiimoteDarwin
but I'm sure this can be done more elegantly.