[AArch64] Workaround builtin byteswap bug. #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add a comment saying what version/toolchain this occurs in on Android. That way it can be tested against later. |
The builtin byteswap routines cause critical failure on AArch64 when built with the Android toolchain. I didn't experience this issue when building for Linux using a local qemu chroot. Seems to be only an issue with the Android toolchain when building AArch64. Use our generic version instead.
Sonicadvance1
force-pushed
the
fix_aarch64_bswap
branch
from
ef25821
to
c27ee21
Compare
Sonicadvance1
added a commit
that referenced
this pull request
Nov 30, 2014
[AArch64] Workaround builtin byteswap bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin byteswap routines cause critical failure on AArch64 when built with the Android toolchain.
I didn't experience this issue when building for Linux using a local qemu chroot.
Seems to be only an issue with the Android toolchain when building AArch64.
Use our generic versions instead