JIT: remove unused flag. #1645
Merged
JIT: remove unused flag. #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both this and m_enable_blr_optimization exists; which one should we keep? optimizeStack kinda makes more sense but I'm not sure if we can replace m_enable_blr_optimization with it |
|
Probably not a good idea to reuse the flag for a different optimization; if anyone is digging through history, it'll get really confusing. (optimizeStack was used to control a hack that used unsafe code for loads relative to the stack pointer.) |
|
Ahhhhhhhh, I see, I didn't realize it was something different. This PR's fine then, though I'm curious why it ended up being removed (like what broke it?) |
|
IIRC, fastmem made it obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup; no functional change.