virtual vertex loader #1713
Merged
virtual vertex loader #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degasus
force-pushed
the
vertex-loader
branch
from
43f7710
to
1d702d2
Compare
| } | ||
| }; | ||
|
|
||
| namespace std |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Not sure about "remove inlined getters…" having an explicit getter provides an indicator to people reading that a variable is intentionally part of the public interface of a class, and it generally makes changing the implementation of a class easier. Not very important either way, though. |
| @@ -117,7 +117,7 @@ template <typename I> | |||
| void Color_ReadIndex_16b_565() | |||
| { | |||
| auto const Index = DataRead<I>(); | |||
| u16 val = Common::swap16(*(const u16 *)(cached_arraybases[ARRAY_COLOR+colIndex] + (Index * g_main_cp_state.array_strides[ARRAY_COLOR+colIndex]))); | |||
| u16 val = Common::swap16(*(const u16 *)(cached_arraybases[ARRAY_COLOR+VertexLoader::m_current_loader->m_colIndex] + (Index * g_main_cp_state.array_strides[ARRAY_COLOR+VertexLoader::m_current_loader->m_colIndex]))); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
degasus
force-pushed
the
vertex-loader
branch
6 times, most recently
from
1deede0
to
dbe0f95
Compare
| @@ -150,11 +136,14 @@ void VertexLoader::CompileVertexTranslator() | |||
|
|
|||
| m_compiledCode = GetCodePtr(); | |||
| // We only use RAX (caller saved) and RBX (callee saved). | |||
| ABI_PushRegistersAndAdjustStack({RBX}, 8); | |||
| ABI_PushRegistersAndAdjustStack({RBX, RBP}, 16); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
degasus
force-pushed
the
vertex-loader
branch
from
dbe0f95
to
6d68040
Compare
They are used to remove the flush amounts, but as we don't flush anymore on vertex loader changes (only on native vertex format right now), this optimization is now unneeded. This will allow us to hard code the frac factors within the vertex loaders.
Not needed for unordered map.
They just blow up the code.
degasus
force-pushed
the
vertex-loader
branch
from
6d68040
to
f37bc18
Compare
degasus
force-pushed
the
vertex-loader
branch
from
f37bc18
to
325e8e3
Compare
|
Any new comments? |
|
The last commit fixes issue 7442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the vertex loader as virtual. It also splits the common functions into the base class, so a jit loader can also use them.
I'm not quite sure if the last commit is worth. Likely only if we add the m_current_loader as parameter for all loaders.