Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Add in/out qualifiers to centroid storage qualifier. #1715

Merged
merged 1 commit into from
Dec 19, 2014

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Dec 19, 2014

Attempt at fixing Issue 7953 and this forum post.

Fixes shaders for GPUs that don't support GL_ARB_shading_language_420pack.
@degasus
Copy link
Member

degasus commented Dec 19, 2014

LGTM

degasus added a commit that referenced this pull request Dec 19, 2014
VideoCommon: Add in/out qualifiers to centroid storage qualifier.
@degasus degasus merged commit ca18e51 into dolphin-emu:master Dec 19, 2014
@PatrickFerry
Copy link
Member

This breaks OpenGL on my AMD R9 290.
I get "Failed to compile vertex shader!" errors with this.
Also "Failed to compile pixel shader!" errors.
Do you want dumps?

@fuel-pcbox
Copy link
Contributor

It's probably just a case of AMD's horrible drivers.

@CrossVR
Copy link
Contributor Author

CrossVR commented Dec 19, 2014

@ZephyrSurfer Try deleting your ShaderCache in Documents/Dolphin Emulator.

@CrossVR CrossVR deleted the geom-interface branch December 19, 2014 16:15
@PatrickFerry
Copy link
Member

@Armada651 I already tried everything before I reported. He's dead, Jim!

@CrossVR
Copy link
Contributor Author

CrossVR commented Dec 19, 2014

@ZephyrSurfer And you're sure it's this PR, not the line-width PR before it?

And yes, I'd like to see the dumps.

@PatrickFerry
Copy link
Member

@Armada651 Of course I'm positive this is the right PR.

Sure I'll link them here

@CrossVR
Copy link
Contributor Author

CrossVR commented Dec 19, 2014

Please upload it to pastie.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants