Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FramebufferManager: Support resolving a multi-layered EFB #1720

Merged
merged 3 commits into from
Dec 20, 2014

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Dec 19, 2014

This allows stereoscopy to be used in combination with MSAA.

@degasus
Copy link
Member

degasus commented Dec 20, 2014

@Armada651: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


LGTM
@dolphin-emu-bot allowmerge

@Sonicadvance1
Copy link
Contributor

Can we also attempt to get MSAA working again on GLES?

@CrossVR
Copy link
Contributor Author

CrossVR commented Dec 20, 2014

Stereo 3D or normal 2D MSAA? If 2D MSAA is broken, since when?

m_efbFramebuffer = 0;
glDeleteFramebuffers(m_EFBLayers, m_efbFramebuffer);
glDeleteFramebuffers(m_EFBLayers, m_resolvedFramebuffer);
delete m_efbFramebuffer;

This comment was marked as off-topic.

This comment was marked as off-topic.

@CrossVR CrossVR force-pushed the stereo-msaa branch 3 times, most recently from 4296675 to 9fe1be6 Compare December 20, 2014 13:32
dolphin-emu-bot added a commit that referenced this pull request Dec 20, 2014
FramebufferManager: Support resolving a multi-layered EFB
@dolphin-emu-bot dolphin-emu-bot merged commit f978d14 into dolphin-emu:master Dec 20, 2014
@feilen feilen mentioned this pull request Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants