Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPLLE: Silence -Wshadow warning and conform more to style. #1760

Merged
merged 1 commit into from Dec 28, 2014
Merged

DSPLLE: Silence -Wshadow warning and conform more to style. #1760

merged 1 commit into from Dec 28, 2014

Conversation

rohit-n
Copy link
Member

@rohit-n rohit-n commented Dec 23, 2014

No description provided.

@skidau
Copy link
Contributor

skidau commented Dec 23, 2014

The commit message does not require the DSPLLE prefix (it is evident from the filename).

@dolphin-emu-bot rebuild

@Tilka
Copy link
Member

Tilka commented Dec 27, 2014

lgtm

if (isHLE != false && p.GetMode() == PointerWrap::MODE_READ)
bool is_hle = false;
p.Do(is_hle);
if (is_hle != false && p.GetMode() == PointerWrap::MODE_READ)

This comment was marked as off-topic.

@Sonicadvance1
Copy link
Contributor

@dolphin-emu-bot rebuild

Sonicadvance1 added a commit that referenced this pull request Dec 28, 2014
DSPLLE: Silence -Wshadow warning and conform more to style.
@Sonicadvance1 Sonicadvance1 merged commit a09d854 into dolphin-emu:master Dec 28, 2014
@rohit-n rohit-n deleted the shadow branch December 29, 2014 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants