Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7968: Added keybinds for increasing, decreasing, and muting audio. #1782

Merged
merged 2 commits into from Jan 8, 2015

Conversation

FL-dolphinemu
Copy link
Contributor

No description provided.

@Antidote
Copy link
Contributor

I think that's actually a pretty useful addition.

_("Volume up"),
_("Volume down"),
_("Volume toggle mute"),

This comment was marked as off-topic.

@FL-dolphinemu
Copy link
Contributor Author

Thanks for your feedback. I've made the changes, and will push them shortly.

@phire
Copy link
Member

phire commented Jan 1, 2015

@dolphin-emu-bot rebuild


{ "VolumeUp", 0, 0 /* wxMOD_NONE */ },
{ "VolumeDown", 0, 0 /* wxMOD_NONE */ },
{ "VolumeToggleMute", 0, 0 /* wxMOD_NONE */ },

This comment was marked as off-topic.

This comment was marked as off-topic.

@phire
Copy link
Member

phire commented Jan 1, 2015

This looks good, I think it should be merged reasonable soon.

int& currentVolume = SConfig::GetInstance().m_Volume;
currentVolume -= offset;
if (currentVolume < AUDIO_VOLUME_MIN)
currentVolume = AUDIO_VOLUME_MIN;

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@OussamaDanba
Copy link
Contributor

For this PR the most sensible option to me seems to set the minimum in the UI to 0%, this way it is possible to "mute" dolphin without using keybindings. We should keep the unmute on change volume behaviour for now. After this PR is merged a followup PR is made which deals with the UI.

My proposal for the UI:

  • When a user mutes dolphin using the keybinding the UI slider stays on the same place but the percentage gets replaced with a muted icon and we don't unmute when the volume is changed.
    • This allows for a way to change the volume without unmuting and we have UI feedback.
  • Lowering the volume to 0% should not show a muted icon to prevent confusion since there will be no good way to tell if it's at 0% or muted.
  • A graphical overlay is possible I think but is limited to text only.
    • Another way of doing this is to add a volume slider in the main UI instead of a separate window. Personally I'm not really fond of this idea. I'd rather avoid moving parts in the main UI.

Note: We can't add an extra button unless the layout is changed, which I'd like to avoid.

@JMC47
Copy link
Contributor

JMC47 commented Jan 7, 2015

Regardless of how people want the very specifics of this feature to work, are we agreed that this should be added? I think it's a nice feature, and it would be useful, especially for streaming Dolphin.

@OussamaDanba
Copy link
Contributor

I would be ok with adding this feature. It won't get in your way if you don't want to use it and it's useful in certain scenarios.

skidau added a commit that referenced this pull request Jan 8, 2015
Issue 7968: Added keybinds for increasing, decreasing, and muting audio.
@skidau skidau merged commit 25c6f6e into dolphin-emu:master Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants