New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 7968: Added keybinds for increasing, decreasing, and muting audio. #1782
Conversation
I think that's actually a pretty useful addition. |
_("Volume up"), | ||
_("Volume down"), | ||
_("Volume toggle mute"), | ||
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Thanks for your feedback. I've made the changes, and will push them shortly. |
Feedback from Antidote and lioncash.
@dolphin-emu-bot rebuild |
|
||
{ "VolumeUp", 0, 0 /* wxMOD_NONE */ }, | ||
{ "VolumeDown", 0, 0 /* wxMOD_NONE */ }, | ||
{ "VolumeToggleMute", 0, 0 /* wxMOD_NONE */ }, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This looks good, I think it should be merged reasonable soon. |
int& currentVolume = SConfig::GetInstance().m_Volume; | ||
currentVolume -= offset; | ||
if (currentVolume < AUDIO_VOLUME_MIN) | ||
currentVolume = AUDIO_VOLUME_MIN; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
For this PR the most sensible option to me seems to set the minimum in the UI to 0%, this way it is possible to "mute" dolphin without using keybindings. We should keep the unmute on change volume behaviour for now. After this PR is merged a followup PR is made which deals with the UI. My proposal for the UI:
Note: We can't add an extra button unless the layout is changed, which I'd like to avoid. |
Regardless of how people want the very specifics of this feature to work, are we agreed that this should be added? I think it's a nice feature, and it would be useful, especially for streaming Dolphin. |
I would be ok with adding this feature. It won't get in your way if you don't want to use it and it's useful in certain scenarios. |
Issue 7968: Added keybinds for increasing, decreasing, and muting audio.
No description provided.