Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: simplify some expressions #1819

Merged
merged 1 commit into from
Jan 6, 2015
Merged

CMake: simplify some expressions #1819

merged 1 commit into from
Jan 6, 2015

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jan 3, 2015

  • use STREQUAL instead of MATCHES when not checking a regex
  • use WIN32/APPLE instead of manually checking CMAKE_SYSTEM_NAME
  • remove some duplicate parentheses

@BhaaLseN
Copy link
Member

BhaaLseN commented Jan 3, 2015

Are the ${CMAKE_SYSTEM_NAME} STREQUAL "Linux" ok like that? ie. does the system name always spell "Linux" and exactly that on Linux, or could it possibly include kernel/version numbers?

And: is there no equivalent identifier for Linux, like there is for WIN32, APPLE and ANDROID?

@Tilka
Copy link
Member Author

Tilka commented Jan 3, 2015

From the CMake documentation:

On systems that have the uname command, this variable is set to the output of uname -s.

And no, there's no LINUX variable, only UNIX.

@waddlesplash
Copy link
Contributor

LGTM

degasus added a commit that referenced this pull request Jan 6, 2015
CMake: simplify some expressions
@degasus degasus merged commit d8d4c94 into dolphin-emu:master Jan 6, 2015
@Tilka Tilka deleted the cmake branch January 6, 2015 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants