New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D3D: allow selecting adapters with no outputs. #1904
Conversation
The result might be a little iffy in complicated situations (i.e. you have three graphics cards and monitors hooked up to two of them), but we really need better UI for such cases anyway.
Ping. |
D3D: allow selecting adapters with no outputs.
@magumagu Hello, I tested it on the Optimus graphics, it's not working. Sorry, if I reported it to a wrong place, I'm new here :) |
@BFG1992 IIRC, you need to select built-in & then make sure you're launching Dolphin with the NVIDIA card with a right-click or the NVIDIA Control Panel. |
Here is fine. Wait a sec, I just took another look at this... and this actually shouldn't work; I have no idea why it works for the WARP renderer. Calling Present() on a swap chain for an adapter that doesn't have any outputs shouldn't do anything useful. I'll submit another PR to clean up the mess. |
Filtering out WARP specifically is easy enough, but there really isn't any reason to: from the perspective of Dolphin, there isn't really any difference between WARP and any other adapter that isn't attached to an output. |
I think the proper way to use the D3D api is to detect a request for WARP and change the way you call
Yes, and the above testers point out why it doesn't really make sense to just blindly allow all adapters...? |
Well, we don't necessarily have to perform rendering on the same adapter that we perform output on... maybe not worth the effort to implement support for that, though. |
@bb010g I know about it, but it was said that
So I thought that this PR was made to remove the need to additionally configure NVIDIA Control Panel or to launch the emu via GPU selecting in context menu. So I ran it on default Intel chip, to see how it will (or won't) switch to NVIDIA with this new PR merged. Before it was throwing an alert "Failed to enumerate outputs", and now just hangs. P.S.: Sorry for my English, it's pretty rough :) |
@BFG1992 Thanks for the extra info... that's a little weird, but I'll see what I can do. |
The result might be a little iffy in complicated situations (e.g. you have three graphics cards and monitors hooked up to two of them), but we really need better UI for such cases anyway.
This change has two benefits: