Fix Intellisense error spam on Visual Studio. #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neobrain care to review? |
| // This constructor might be considered ambiguous: | ||
| // Would it initialize the storage or just the bitfield? | ||
| // Hence, delete it. Use the assignment operator to set bitfield values! | ||
| // MSVC 2013 Intellisense doesn't like this declaration, so disable |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM other than the comment I added. Deleting that constructor is indeed not critical and is just added to prevent accidental misuse of BitField. |
magumagu
force-pushed
the
intellisense-error-fix
branch
from
bedd974
to
9e2026f
Compare
|
Updated with improved comment. |
| // This constructor might be considered ambiguous: | ||
| // Would it initialize the storage or just the bitfield? | ||
| // Hence, delete it. Use the assignment operator to set bitfield values! | ||
| // MSVC 2013 Intellisense complains that this declaration isn't allowed | ||
| // in a union member, so disable it on Windows. | ||
| BitField(T val) = delete; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Intellisense doesn't like defines in PCH files, and it doesn't like the deleted constructor for BitField. (I think it's being overly strict about the "must have no non-default constructors" rule for classes in unions.)
magumagu
force-pushed
the
intellisense-error-fix
branch
from
9e2026f
to
3aa3002
Compare
skidau
added a commit
that referenced
this pull request
Jan 25, 2015
Fix Intellisense error spam on Visual Studio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intellisense doesn't like defines in PCH files, and it doesn't like the deleted
constructor for BitField. (I think it's being overly strict about the
"must have no non-default constructors" rule for classes in unions.)