Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JC4E01.ini to use ascii single quote #1937

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Conversation

Parlane
Copy link
Member

@Parlane Parlane commented Jan 21, 2015

No description provided.

@Buddybenj
Copy link
Contributor

Thanks for this. This will fix the merge conflicts in PR #1890.

@Parlane
Copy link
Member Author

Parlane commented Jan 21, 2015

@Buddybenj This won't fix your issue as there is another game that uses the curved single quote. This pr was a test to see what central is doing with the diff.

@degasus
Copy link
Member

degasus commented Jan 21, 2015

please use your own fork for PRs :/

@Parlane
Copy link
Member Author

Parlane commented Jan 21, 2015

@degasus This is not a real PR. I was testing what Github was doing when it created the patch.

@CarlKenner
Copy link
Contributor

Why is there a single quote there anyway?
That is just a comment, right?
Or is there something exact I have to put there when I add my own ini files?

@Parlane
Copy link
Member Author

Parlane commented Jan 21, 2015

@CarlKenner It's just grammatically correct, no technical need for it to be.

@Buddybenj
Copy link
Contributor

@Parlane Oops, I was on mobile so I didn't see the Buildbot. Good to see it's not a problem on my end though. Perhaps we should try to delete the file, push the changes, then add the file back in with the ASCII single quote instead (I don't know if that would work or not).

BTW, I did a search and confirmed that JC4E01 is the only one that does have the curved (non-ASCII) single quote. What other game did you think used the curved quote?

@Buddybenj
Copy link
Contributor

Any news on if the issue with the Buildbot is going to be fixed soon?

delroth added a commit that referenced this pull request Feb 23, 2015
Change JC4E01.ini to use ascii single quote
@delroth delroth merged commit d4733b5 into master Feb 23, 2015
@Parlane Parlane deleted the Parlane-patch-1 branch February 23, 2015 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants