VolumeWiiCrypted: Decryption optimization #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,34 +67,40 @@ bool CVolumeWiiCrypted::Read(u64 _ReadOffset, u64 _Length, u8* _pBuffer, bool de | |||
| { | |||
| static unsigned char IV[16]; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
The block doesn't have to be read if it already is in m_pBuffer.
JosJuice
force-pushed
the
dvd-decryption-optimization
branch
from
c07e848
to
521ccd7
Compare
|
lgtm (although this code could use a few documentation-only variables and symbolic constants). |
|
I kinda agree with @Tilka. Maybe add a static const int (or uint depending on what you prefer) that gives 0x7C00 a name. LGTM after that's addressed. |
FioraAeterna
added a commit
that referenced
this pull request
Feb 8, 2015
VolumeWiiCrypted: Decryption optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block doesn't have to be read if it already is in m_pBuffer.
@tueidj: This should fix the problem you pointed out.