Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGL: Fix a memory leak that would occur every time a game is launched #1989

Merged
merged 1 commit into from Jan 31, 2015

Conversation

lioncash
Copy link
Member

The GL interface would always be re-initialized, but the previous instance would never be deleted.

@Mullin
Copy link
Contributor

Mullin commented Jan 31, 2015

/Source/Core/VideoBackends/OGL/main.cpp: In member function 'virtual void OGL::VideoBackend::Shutdown()':
/Source/Core/VideoBackends/OGL/main.cpp:227:9: warning: deleting object of polymorphic class type 'cInterfaceBase' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
delete GLInterface;

@lioncash
Copy link
Member Author

@Mullin should be all good now.

@Tilka
Copy link
Member

Tilka commented Jan 31, 2015

VideoSoftware supposedly has the same leak.

@Mullin
Copy link
Contributor

Mullin commented Jan 31, 2015

LGTM

@lioncash
Copy link
Member Author

@Tilka Should be good now.

@Tilka
Copy link
Member

Tilka commented Jan 31, 2015

lgtm

degasus added a commit that referenced this pull request Jan 31, 2015
OGL: Fix a memory leak that would occur every time a game is launched
@degasus degasus merged commit ca5e2e6 into dolphin-emu:master Jan 31, 2015
@lioncash lioncash deleted the leak branch January 31, 2015 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants