Use the C locale for non-Windows CharArrayFromFormatV() and StringFromFormat()

[randomstuff]

The Windows implementations of CharArrayFromFormatV() and StringFromFormat() use the "C"/".1252" locale instead of the user locale (using _vsnprintf_l). On non-Windows, the user locale was used.

This leads to bugs on non-Windows: the Overclock parameter was serialised with the user locale (0,279322 in some locale) and was interpreted back as 0 (because the "C" locale is used for parsing the string).

Make non-Windows CharArrayFromFormatV() and StringFromFormat() consistent with their Windows counterpart.

[BhaaLseN]

Hmm, shouldn't we consistently use the C locale everywhere, for everything? User locale is always bound to make problems when inter-opping, or when assuming something/nothing about the values and their representation.

[randomstuff]

The non-C locale is used (and setup) by the GUI toolkit (wxWidgets via wxLocale) in order to handle localisation.

[CrossVR]

@dolphin-emu-bot rebuild

The code looks good to me.

[randomstuff]

uselocale and friends are available in Android API 21. Since dolphin is build with android:minSdkVersion="18", I guess I should use the old code (without locale_t) for Android.

[CrossVR]

@randomstuff IIRC uselocale() in the NDK doesn't do anything, as far as I know Android always assumes C locale.

[CrossVR]

@dolphin-emu-bot rebuild

[randomstuff]

Yes, recent version of bionic have locale management fucntions but they only support "C" vs "C.UTF-8" (the default).

[Mullin]

LGTM

[randomstuff]

This bug is stil on master. Can this be merged or should another fix be used ?

[degasus]

I'm for merging as it is.

[Nucleoprotein]

This was reverted ? I get problem with saving CPU Override in r6963 on Windows.

[randomstuff]

@Tapcio: This specific patch does not change the behaviour on Windows. I think, it was supposed to have been fixed on Windows.

[Nucleoprotein]

It's not fixed on Windows.
My Windows is set to Polish locale and it saves coma instead of dot when saving CPU Override to ini.. Then when I re-run Dolphin CPU Override is set to 0%, so then I cant run game - I need to uncheck option. This issue is really even more annoying when I want to enable CPU Override, because it is always 0 and slider is disabled (grayed out) when option is disabled so enabling it causes game freeze (ie. sets slider value - 0% ...).

// sorry for bad english

[BhaaLseN]

Can you please create an issue on our issue tracker, instead of posting on a closed PR? This would help us more in keeping track of issues that are still present.

[Nucleoprotein]

Hym, there already is: https://code.google.com/p/dolphin-emu/issues/detail?id=8095