Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the C locale for non-Windows CharArrayFromFormatV() and StringFromFormat() #2004

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Use the C locale for non-Windows CharArrayFromFormatV() and StringFromFormat() #2004

merged 1 commit into from
Feb 25, 2015

Commits on Feb 4, 2015

  1. Use the C locale for non-Windows CharArrayFromFormatV() and StringFro… 

    …mFormat()

The Windows implementations of CharArrayFromFormatV() and
StringFromFormat() use the "C"/".1252" locale instead of the user
locale (using _vsnprintf_l). On non-Windows, the user locale was used.

This leads to bugs on non-Windows: the Overclock parameter was
serialised with the user locale ("0,279322" in some locale) and was
interpreted back as "0" (because the C locale is used for parsing the
string).

Make non-Windows CharArrayFromFormatV() and StringFromFormat()
consistent with their Windows counterpart.

The locale code is not enables for Android:: uselocale is only
available since API 21 and API 21 only supports C and C.UTF-8.
    @randomstuff
    randomstuff committed Feb 4, 2015
    Configuration menu
    Copy the full SHA
    266d50c View commit details
    Browse the repository at this point in the history