-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix our memory map to match the GameCube. #2040
Conversation
{nullptr, 0x2C0000000, RAM_SIZE, MV_MIRROR_PREVIOUS}, | ||
{nullptr, 0x2C2000000, RAM_SIZE, MV_MIRROR_PREVIOUS}, | ||
{nullptr, 0x2C4000000, RAM_SIZE, MV_MIRROR_PREVIOUS}, | ||
{nullptr, 0x2C6000000, RAM_SIZE, MV_MIRROR_PREVIOUS}, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This fixes a hang in Rogue Squadron 2: Rogue Leader in Hoth. |
Might want to retest issue 5900 |
@skidau Just tested it. Broken by PR1856 but this does not fix it. |
@ZephyrSurfer Broken... how, exactly? |
@magumagu There is a lot of messages like |
@magumagu To be more clear. Eduke32 Wii no longer even boots, instead a lot of these messages appear. Disabling Panic Handlers does not help. Caused by the first commit in that PR. |
@ZephyrSurfer Hmm... that's sort of surprising. That said, it's not the same bug; please file an issue report and assign it to me. |
Ping. |
IMO this needs a comment a) explaining what the heck is going on here (for posterity!) and b) explaining why we don't just mirror it a whole bunch of times. Also possibly c) what happens if something is in the upper 8MB of a 32MB chunk. |
Now with more comments. |
This basically just restores the RAM mirroring that existed before PR1856 (address translation).
Try to fix our memory map to match the GameCube.
This basically just restores the RAM mirroring that existed before PR1856
(address translation), and fixes our memory map so it matches the
behavior of the slow path. This also gets rid of the hack in the JIT to
force the RAM mirroring case onto the slow path; it shouldn't be necessary
anymore.
Still need to verify this against hardware.