Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix our memory map to match the GameCube. #2040

Merged
merged 1 commit into from
Feb 19, 2015

Conversation

magumagu
Copy link
Contributor

This basically just restores the RAM mirroring that existed before PR1856
(address translation), and fixes our memory map so it matches the
behavior of the slow path. This also gets rid of the hack in the JIT to
force the RAM mirroring case onto the slow path; it shouldn't be necessary
anymore.

Still need to verify this against hardware.

{nullptr, 0x2C0000000, RAM_SIZE, MV_MIRROR_PREVIOUS},
{nullptr, 0x2C2000000, RAM_SIZE, MV_MIRROR_PREVIOUS},
{nullptr, 0x2C4000000, RAM_SIZE, MV_MIRROR_PREVIOUS},
{nullptr, 0x2C6000000, RAM_SIZE, MV_MIRROR_PREVIOUS},

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@JMC47
Copy link
Contributor

JMC47 commented Feb 14, 2015

This fixes a hang in Rogue Squadron 2: Rogue Leader in Hoth.

@skidau
Copy link
Contributor

skidau commented Feb 16, 2015

Might want to retest issue 5900

https://code.google.com/p/dolphin-emu/issues/detail?id=5900

@PatrickFerry
Copy link
Member

@skidau Just tested it. Broken by PR1856 but this does not fix it.

@magumagu
Copy link
Contributor Author

@ZephyrSurfer Broken... how, exactly?

@PatrickFerry
Copy link
Member

@magumagu There is a lot of messages like
"Unable to resolve read address 8004358 PC 0"

@PatrickFerry
Copy link
Member

@magumagu To be more clear. Eduke32 Wii no longer even boots, instead a lot of these messages appear. Disabling Panic Handlers does not help.

Caused by the first commit in that PR.

@magumagu
Copy link
Contributor Author

@ZephyrSurfer Hmm... that's sort of surprising. That said, it's not the same bug; please file an issue report and assign it to me.

@magumagu
Copy link
Contributor Author

Ping.

@FioraAeterna
Copy link
Contributor

IMO this needs a comment a) explaining what the heck is going on here (for posterity!) and b) explaining why we don't just mirror it a whole bunch of times.

Also possibly c) what happens if something is in the upper 8MB of a 32MB chunk.

@magumagu
Copy link
Contributor Author

Now with more comments.

This basically just restores the RAM mirroring that existed before PR1856
(address translation).
magumagu added a commit that referenced this pull request Feb 19, 2015
Try to fix our memory map to match the GameCube.
@magumagu magumagu merged commit 0360e01 into dolphin-emu:master Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants