Add Datel AGP save commands for SRAM/FRAM. Improve EEPROM. #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. Whoops. |
|
This PR fixes my GBA games in the Advance Game Port as I said on the forums. I guess flash memory is pretty rare compared to eeprom? |
| @@ -191,7 +206,7 @@ u32 CEXIAgp::ImmRead(u32 _uSize) | |||
|
|
|||
| void CEXIAgp::ImmWrite(u32 _uData, u32 _uSize) | |||
| { | |||
| if ((_uSize == 1) && ((_uData & 0xFF000000) == 0)) | |||
| if ((_uSize == 1) && ((_uData & 0xFF000000) == 0)) // Execute current command? | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Would you please squash the commits down to one commit? |
greyrogue
changed the title
| { | ||
| // Handle endian write - could be done with byte access in 0xAE commands instead | ||
| std::vector<u8> temp_eeprom; | ||
| temp_eeprom.resize(m_eeprom_size); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I've seen someone on IRC say that with Fire Emblem (not sure which one?) it's not saving properly and zeroes out, but I'm not able to reproduce save problems right now. I did some pretty thorough testing, using the PR build instead of my custom build with the hanging fix. Test 1:
Test 2:
Test 3:
|
|
Sorry to be picky, but would you please squash the two commits? |
Handle possible endian file read issues at file access time instead of using Swap64 on every access. Code comments and clean up.
|
@dolphin-emu-bot rebuild |
skidau
added a commit
that referenced
this pull request
Feb 15, 2015
Add Datel AGP save commands for SRAM/FRAM. Improve EEPROM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for the 0xAE04 and 0xAE07 commands of the AGP (doesn't include Flash ROM).