Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guide: Added rule for do-while loops #2081

Merged
merged 1 commit into from Feb 20, 2015

Conversation

Stevoisiak
Copy link
Contributor

No description provided.

@phire
Copy link
Member

phire commented Feb 20, 2015

lgtm

@phire
Copy link
Member

phire commented Feb 20, 2015

Er, actually that doesn't render in markdown correctly.

It puts it all on the same line (do { } while (false);) which is not something we want to recommend.

@@ -159,6 +159,12 @@ private:
- Empty-bodied loops should use braces after their header, not a semicolon.
- Yes: `while (condition) {}`
- No: `while (condition);`
- For do-while loops, place 'while' on the same line as the closing brackets
```c++

This comment was marked as off-topic.

@Stevoisiak
Copy link
Contributor Author

Should be good now. Seems like there was an issue with my markup viewer before.

lioncash added a commit that referenced this pull request Feb 20, 2015
Style Guide: Added rule for do-while loops
@lioncash lioncash merged commit ec065ee into dolphin-emu:master Feb 20, 2015
@Stevoisiak Stevoisiak deleted the UpdateStyleGuide branch February 20, 2015 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants