Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGL: support palette texture decoding #2085

Merged
merged 1 commit into from Feb 24, 2015

Conversation

degasus
Copy link
Member

@degasus degasus commented Feb 20, 2015

No description provided.

@degasus degasus force-pushed the ogl_paletted branch 5 times, most recently from cec6142 to 5a55ca3 Compare February 21, 2015 00:09
}


TextureCache::~TextureCache()
{
DeleteShaders();
delete s_palette_stream_buffer;
s_palette_stream_buffer = nullptr;
glDeleteTextures(1, &s_palette_resolv_texture);

This comment was marked as off-topic.

{
// TODO: Implement.
return;
g_renderer->ResetAPIState();

This comment was marked as off-topic.

This comment was marked as off-topic.

@Mullin
Copy link
Contributor

Mullin commented Feb 21, 2015

LGTM 👍

@@ -465,6 +465,7 @@ Renderer::Renderer()
g_Config.backend_info.bSupportsBBox = GLExtensions::Supports("GL_ARB_shader_storage_buffer_object");
g_Config.backend_info.bSupportsGSInstancing = GLExtensions::Supports("GL_ARB_gpu_shader5");
g_Config.backend_info.bSupportsGeometryShaders = GLExtensions::Version() >= 320;
g_Config.backend_info.bSupportsPaletteConversion = GLExtensions::Supports("GL_ARB_texture_buffer_object");

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@delroth
Copy link
Member

delroth commented Feb 21, 2015

I'm assuming @degasus will fix it on GLES before considering to get this merged.

@Linktothepast
Copy link
Contributor

Android is using the default gameinis too? Those are made taking a compatibility approach and in regard to pc hardware, in android i think compatibility via settings is the least of the worries when most games are unplayable due to speed restrictions even with the fastest settings.

@degasus
Copy link
Member Author

degasus commented Feb 22, 2015

This PR is ready imo, so reviews are welcome ;D

@degasus degasus force-pushed the ogl_paletted branch 2 times, most recently from 8d0b223 to fdc3e17 Compare February 22, 2015 10:29
@Mullin
Copy link
Contributor

Mullin commented Feb 22, 2015

👍

@@ -140,7 +140,7 @@ static void InitBackendInfo()
g_Config.backend_info.bSupportsGeometryShaders = true;
g_Config.backend_info.bSupports3DVision = false;
g_Config.backend_info.bSupportsPostProcessing = true;
g_Config.backend_info.bSupportsPaletteConversion = false;
//g_Config.backend_info.bSupportsPaletteConversion = true; // is GPU dependent and must be set in renderer

This comment was marked as off-topic.

This comment was marked as off-topic.

@degasus
Copy link
Member Author

degasus commented Feb 23, 2015

HdkR> I'm fine with it

degasus added a commit that referenced this pull request Feb 24, 2015
OGL: support palette texture decoding
@degasus degasus merged commit 5fc62ac into dolphin-emu:master Feb 24, 2015
@ghost
Copy link

ghost commented Feb 24, 2015

What a win for Simpsons and Twilight Princess.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • fortune-street on ogl-lin-mesa: diff
  • fortune-street-white-box on ogl-lin-mesa: diff
  • simpsons-tev on ogl-lin-mesa: diff
  • ztp-grass on ogl-lin-mesa: diff
  • fortune-street on ogl-lin-nv: diff
  • fortune-street-white-box on ogl-lin-nv: diff
  • simpsons-tev on ogl-lin-nv: diff
  • ztp-grass on ogl-lin-nv: diff

automated-fifoci-reporter

@degasus degasus deleted the ogl_paletted branch August 9, 2015 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
8 participants