AudioCommon: Remove usages of volatile variables. #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only ever used in these two sound streams. Seems silly to have it as a class member. Converted it to an atomic as well.
| @@ -39,7 +41,7 @@ class AlsaSound final : public SoundStream | |||
| // 0 = continue | |||
| // 1 = shutdown | |||
| // 2 = done shutting down. | |||
| volatile int thread_data; | |||
| std::atomic<int> thread_data; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@comex: Addressed in the recent-most commit. |
| @@ -19,6 +20,7 @@ class AOSound final : public SoundStream | |||
| { | |||
| #if defined(HAVE_AO) && HAVE_AO | |||
| std::thread thread; | |||
| std::atomic<bool> m_run_thread; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
skidau
added a commit
that referenced
this pull request
May 14, 2015
AudioCommon: Remove usages of volatile variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts them over to using atomics.