Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More miscellaneous Qt fixes #2390

Merged
merged 4 commits into from May 26, 2015
Merged

More miscellaneous Qt fixes #2390

merged 4 commits into from May 26, 2015

Conversation

s-mcf
Copy link
Contributor

@s-mcf s-mcf commented May 10, 2015

All the other stuff I have deserves its own PR, so this is probably the last 'misc fixes' PR for a while.

This PR contains the following:

  • Fix a crash that would occur if a user Alt+F4'd with a game running
  • Size the window up to fit the game if it's smaller than the IR (the user can still scale the window up or down once the game launches if they so choose)
  • Fix the About Qt menu item not actually doing anything
  • Bring in keyboard shortcuts from the wx UI.

What I'm working on next in rough order:

  • Save states
  • Movies
  • Config window
  • TAS (might need some help with this as I'm not too familiar with what a good TAS setup looks like)

@JMC47
Copy link
Contributor

JMC47 commented May 10, 2015

@dolphin-emu-bot rebuild

@@ -92,6 +93,10 @@ DMainWindow::~DMainWindow()
{
}

void DMainWindow::closeEvent(QCloseEvent *ce){

This comment was marked as off-topic.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@s-mcf
Copy link
Contributor Author

s-mcf commented May 11, 2015

Is this an issue with FifoCI? Nothing here should affect rendering...

@BhaaLseN
Copy link
Member

The EC2 instances were stuck for quite some time, so they seem to be a bit wonky now that they had some vacation.

Sonicadvance1 added a commit that referenced this pull request May 26, 2015
@Sonicadvance1 Sonicadvance1 merged commit f706518 into dolphin-emu:master May 26, 2015
@leoetlino leoetlino modified the milestone: Qt Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants