DolphinQt: Use short GC game titles in grid view #2403
Conversation
|
Can you provide an image? |
|
Old: New: |
|
I think I like the old behaviour better. As evidenced by Wind Waker not all games provide a particularly good short name. |
|
@printo Because "The Legend of Zelda: The..." is so much better. I guess you can select it to see? |
|
Maybe a "use short title in grid view" config option is in order? |
|
@comex Yeah it's not a huge difference either way. In that specific case I would argue that including the extra "The..." is superior as the user can determine the game just off the title alone as long as they know that's the only GCN Zelda with that subtitle beginning. I think ideally the UI should be modified so the entire title fits instead of trying to design around it. Maybe make the field have two+ lines instead of one and/or decrease font size. |
|
@pringo In this specific case, users might as well look at the banner and recognize the boat and waves rather than memorizing which games have subtitles that start with The. Using two lines to display names could work for this, but it feels unnecessary when many GC games and pretty much all Wii games fit on one line. I don't think we can go any smaller than the current font size. @JMC47 Since you have a lot of GC games, can you look through them and see if short names are better than long names for the grid view in general? |
|
I prefer the new one (with short name), even in cases where it may not show something useful (see Wind Waker) - main plus is that it doesnt show ellipsis which cause the name to be truncated either way. |
|
This has value for Android as well, for similar reasons, so it gets a +1 from me. Android will also provide a visual way to identify the game, so the fact that it doesn't say "Wind Waker" doesn't really bother me. I think I prefer the more professional appearance of the name without ellipse truncation, even if it doesn't give us a lot of information. |
|
@JosJuice Yeah Wind Waker is still somewhat obvious thanks to the banner. I was thinking there might be a number of other cases where names like this cause issues but I see you've already thought of that. If Wind Waker does end up being the worst case scenario then it's probably not much of an issue at all. Personally I'd still like to see the interface with two lines for game titles as it's not like the grid view is hurting for vertical space but perhaps I'm alone on that opinion. Also a question about the change: does it alter the alphanumeric sorting at all? I can't really tell how that works going by the example image. I could see it causing some potential annoyances depending on how the name is shortened. |
|
I have no idea how the grid view sorting works, but it doesn't seem to be affected by this. |
|
Not sure if this functionality is in it already, (I don't have device handy) if long pressed on the image maybe a toast (http://developer.android.com/guide/topics/ui/notifiers/toasts.html) should be shown with the full name being shown? Short name looks nicer for lots of games while the long name will be better for cases like windwaker who don't fit it will allow for the user to know which game it is. (specifically this is for the android version, for the program version hover over the image for the full name) |
|
@Jofzar This is for the desktop version, not the Android one. |
|
Sorry got a little bit confused about his end paragraph, my message on the end is still relevant to the problem with confusion if the user is not sure what the full title is, while still looking neater and tidy. |
|
I'm quite sure users aren't that dense (though I'll probably be proven wrong in the future). |
|
Qt code LGTM. |
|
This is probably too late, but what about detecting the ":" symbol and using the substring that follows that? I'm pretty sure that 99% time that a ":" is used in a game's title, it is followed with its subtitle e.g. "Wind Waker", "Point of Impact." |
|
@yorkiesandskittles I think that would just make things more confusing. Also the way subtitles are handled in titles isn't consistent. Some games don't even include their subtitle for whatever reason reason, some games ignore the colon, some games use a dash instead, etc. |
|
The only case where you definitely want to see the subtitle is when you have two games with the same main title. There are more cases where displaying only the subtitle is okay, but on the other hand, there are many cases where it's inappropriate. For instance, if you have Example Game and Example Game 2: Electric Boogaloo, showing only "Electric Boogaloo" for the second one would be bad (or possibly acceptable if the main title is fully visible in the banner). We should not overcomplicate this and make things worse for several games just because Zelda WW doesn't look perfect. |
|
Rebase this please. It is a good change, |
GC games with long names store two variations of the name in opening.bnr. This makes the shorter of those names available. For volumes other than GC discs, prefer_long is ignored.
Short titles fit better than long titles.
DolphinQt: Use short GC game titles in grid view
GC games have both a long name and a short name in opening.bnr. Until now, Dolphin has only used the long one. This PR lets callers of
IVolume::GetNames()choose which one they want using a bool parameter. This is used in DolphinQt to display short names in the grid view because they fit well in the available space unlike some long titles. It probably has no use in the wx GUI, but I think it can be appropriate to use in the new Android GUI in the future.