Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC: cosmetic changes #2411

Merged
merged 6 commits into from May 18, 2015
Merged

PowerPC: cosmetic changes #2411

merged 6 commits into from May 18, 2015

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented May 14, 2015

Most of these commits are probably best looked at with --word-diff-regex=. On GitHub you can generate -w diffs by adding ?w=1 to the URL.

@BhaaLseN
Copy link
Member

Not sure about the _ARCH_64 change in JitBase, maybe ping @Sonicadvance1 about that. Otherwise, lgtm.

@Tilka
Copy link
Member Author

Tilka commented May 14, 2015

LogGeneratedX86() is not used on ARM.

@lioncash
Copy link
Member

Looks fine to me

@degasus
Copy link
Member

degasus commented May 15, 2015

But LogGeneratedX86 should be in Jit64Common instead :/

@Tilka
Copy link
Member Author

Tilka commented May 16, 2015

@degasus I'd rather move everything around in one go when we figure out a better way to organize PowerPC/*

FioraAeterna added a commit that referenced this pull request May 18, 2015
PowerPC: cosmetic changes
@FioraAeterna FioraAeterna merged commit b260500 into dolphin-emu:master May 18, 2015
@Tilka Tilka deleted the cosmetic branch May 18, 2015 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants