VertexLoaderX64: generate PIC #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (memory_base <= INT32_MAX) | ||
| MOV(32, R(base_reg), Imm32((u32)memory_base)); | ||
| else | ||
| MOV(64, R(base_reg), Imm64(memory_base)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tilka
referenced
this pull request
in phire/dolphin
May 31, 2015
Move ownership of cached_arraybases from CPMemory to VertexLoaderManager to better match it usage.
Yeah, It's not wise to make assumptions like that. Someone could like move that variable to VertexLoaderManager... |
Address static memory relative to a base register, analog to what we're doing with PPCSTATE in the CPU JIT. This allows executable memory for the vertex loader JIT to be allocated anywhere, not just within 2 GiB of static data. Fixes issue 8180.
|
Whether or not this fixes stuff, it's required for PIE, so let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address static memory relative to a base register, analog to what we're doing with
PPCSTATEin the CPU JIT. This allows executable memory for the vertex loader JIT to be allocated anywhere, not just within 2 GiB of static data.Fixes issue 8180.