Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkeys fixes #2489

Merged
merged 4 commits into from May 31, 2015
Merged

Hotkeys fixes #2489

merged 4 commits into from May 31, 2015

Conversation

degasus
Copy link
Member

@degasus degasus commented May 31, 2015

This PR shall fix some issues with the current hotkey implementation:

  • We now can parse more than one hotkey at the same time, eg pressing F1 while TAB is pressed.
  • Add the missed hotkeys (Open, Change Disc, Refresh List, Exit) and make them working.
  • Change the default key of wiimote home or gcpad start to "!ALT & ENTER" to not pressing home while toggling fullscreen.

lioncash
lioncash reviewed May 31, 2015
View reviewed changes
Source/Core/DolphinWX/Frame.cpp
}
}

void CFrame::ParseHotkeys(wxKeyEvent &event)
{
unsigned int i = NUM_HOTKEYS;

This comment was marked as off-topic.

Sign in to view

@degasus
InputCommon: Change default hotkey for home and start.
bdfea96 
We already use ALT + ENTER for toggling fullscreen.
But as ENTER is both home and start, this buttons will always
also be triggered on toggling fullscreen. Now we check for
those buttons if ALT is not pressed.
So now we're able to toggle fullscreen without pressing home or start.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@degasus
Copy link
Member Author

degasus commented May 31, 2015

Jasper> go for it

degasus added a commit that referenced this pull request May 31, 2015
@degasus
Merge pull request #2489 from degasus/hotkeys
da97d77 
Hotkeys fixes
@degasus degasus merged commit da97d77 into dolphin-emu:master May 31, 2015
@DonelBueno
Copy link

Full Screen has stopped working since the merge of this PR.

@Rukario
Copy link
Contributor

Rukario commented Jun 2, 2015

^ same

@degasus
Copy link
Member Author

degasus commented Jun 2, 2015

Could you please try if PR #2505 fixes the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@degasus @dolphin-emu-bot @DonelBueno @Rukario @lioncash @magcius