Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64] Upstream PPSSPP's emitter changes. #2555

Conversation

Sonicadvance1
Copy link
Contributor

Requires a minor change to in the JIT to make sure everything still works.

0x5555555555555555UL,
};

#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

This comment was marked as off-topic.

@Sonicadvance1 Sonicadvance1 force-pushed the aarch64_rebase_ppsspp_emitter branch from 7b7f0c9 to 05b72c5 Compare June 8, 2015 00:50
Requires a minor change to in the JIT to make sure everything still works.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • mario-sluggers-bar on ogl-lin-nv: diff
  • mii-channel on ogl-lin-nv: diff
  • mtennis-zfreeze on ogl-lin-nv: diff
  • simpsons-tev on ogl-lin-nv: diff
  • sw3-dt on ogl-lin-nv: diff
  • thps4-shadow on ogl-lin-nv: diff
  • tos-invis-char on ogl-lin-nv: diff

automated-fifoci-reporter

Sonicadvance1 added a commit that referenced this pull request Jun 8, 2015
…tter

[AArch64] Upstream PPSSPP's emitter changes.
@Sonicadvance1 Sonicadvance1 merged commit 8c2e5e2 into dolphin-emu:master Jun 8, 2015
@Sonicadvance1 Sonicadvance1 deleted the aarch64_rebase_ppsspp_emitter branch June 8, 2015 03:23
@Icekhaos
Copy link

What are we doing with these?

@Sonicadvance1
Copy link
Contributor Author

What?

@Icekhaos
Copy link

Emitter changes from another emulator.

@Sonicadvance1
Copy link
Contributor Author

The AArch64 emitter that PPSSPP uses is from the Dolphin project.
They've added a few functions and bug fixes to it.
I don't typically try to upstream code from a downstream project(That's their responsibility) but I wanted the codebases to diverge less.

@Icekhaos
Copy link

Alright, good job. I suggest that, for improving upon Dolphin indirectly, that you keep an eye on PPSSPP for more changes that could benefit us Nintendo folk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants