GUI: Re-enable the Tools -> Load Wii System Menu option on emulator start. #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
|
AFAIK this is wrong because it will break if directories are changed midgame (we don't block that, do we?), causing RebuildUserDirectories to be called, which will set the wrong path if it's a netplay game - and even if it's not, it would make more sense to keep the old directory for the remainder of the game rather than breaking the game's view of the filesystem, which is why I set it up that way. Better to fix the system menu launcher a different way. |
AdmiralCurtiss
force-pushed
the
reenable-sysmenu-boot-option
branch
from
5e5a593
to
a9efe9a
Compare
|
Okay, sure. Is it better like this? |
…tart. I believe this was broken when D_SESSION_WIIROOT_IDX was introduced in dc91e8b.
AdmiralCurtiss
force-pushed
the
reenable-sysmenu-boot-option
branch
from
a9efe9a
to
c14773a
Compare
AdmiralCurtiss
changed the title
|
Okay, now it should be fine. |
|
@dolphin-emu-bot rebuild |
|
FYI #2642 is doing pretty much the same thing, as far as I can tell, but more generally. That's probably better than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the Tools -> Load Wii System Menu option on emulator start, which I believe was broken when D_SESSION_WIIROOT_IDX was introduced in dc91e8b. Since that commit, the option was greyed-out when first starting the emulator and was only enabled when a Wii game booted. (UpdateWiiMenuChoice() in FrameTools.cpp uses the regular GetNANDLoader() function, which always uses the session WiiRoot, which was only initialized on game boot.)
I assume it's fine to just initialize it immediately? It'll be re-set in InitializeWiiRoot() anyway.