[AArch64] Fix a couple of bugs in the vertex loader #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular this fixes the 6666 colour format We were loading from the wrong location and it was causing /terrible/ colour changes. This also fixes a bug in the all the colour formats(except 888) where the unaligned path was loading in to the wrong register.
|
Thinking about this, the code can be optimized to nearly double the throughput in most of the colour decodings by using two registers. Each one for each of the two components and then combining them at the end. This would be something to do in a different PR. |
|
LGTM, fixes those strange colors in peach castle. |
Sonicadvance1
added a commit
that referenced
this pull request
Jun 21, 2015
…colour [AArch64] Fix a couple of bugs in the vertex loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this fixes the 6666 colour format
We were loading from the wrong location and it was causing /terrible/ colour changes.
This also fixes a bug in all the colour formats (except 888) where the unaligned path was loading in to the wrong register.