SI_DeviceGCController: Remedy undefined behavior regarding shifts #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left shifting a negative left-hand operand is undefined behavior per section 5.8.2 of the C++11 standard.
|
This changes behavior. You're sure it's correct? |
|
According to YAGCD those are the only button/input bits that are used. I've tested it in Donkey Konga and everything plays as normal. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
lgtm |
Tilka
added a commit
that referenced
this pull request
Jul 12, 2015
SI_DeviceGCController: Remedy undefined behavior regarding shifts
|
The Bongos also use R (for the clap sensor), at least in Donkey Kong Jungle Beat, so this causes some issues in that game now (tested the release before this and it works fine). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left shifting a negative left-hand operand is undefined behavior per section 5.8 subsection 2 of the C++11 standard.