Specified the type of AA in OGL AA settings #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine |
|
aserna3, I'm pretty sure the AA UI labels are in OGL's video backend because they are OGL specific. D3D has an entirely different system for AA that's driver based and outside of our control! You may want to ask degasus and HdkR about that. So I'm glad you didn't change that. Anyway, it looks fine to me! |
lioncash
added a commit
that referenced
this pull request
Aug 12, 2015
Specified the type of AA in OGL AA settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One little UI quirk that mislead me on what Dolphin actually does is the anti-aliasing setting. In OGL it only says "2x, 4x, 8x" and "4x SSAA". To me that's pretty weird and doesn't tell me what the others are. Considering there's a zillion different forms of AA, I think that it would be better to be verbose with what those other settings are. IMO this is a pretty safe change. It takes up no additional UI space. Doesn't even stretch the drop down box.
However, I'm slightly concerned why the AA UI labels were in OGL's video backend and not the videoconfigdialog.cpp file. So I did extensive testing with ZTP in the titlescreen and frame advancing between AA settings to make sure I didn't break anything and AA modes still worked as designed. If others could test this as well that would be very nice. Thanks.