Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit64: implement FPSCR related instructions #2864

Merged
merged 2 commits into from Aug 21, 2015
Merged

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Aug 17, 2015

No description provided.

@lioncash
Copy link
Member

Does mffs set all the top bits of the destination register to 1? (hardware does this)

@Tilka
Copy link
Member Author

Tilka commented Aug 17, 2015

@lioncash: Something like this? Did you do a hardware test? (I'd actually expect something like fctiw where it just makes it a NaN.)

riPS0(_inst.FD) = (0xFFFFFFFFull << 32) | FPSCR.Hex;

@lioncash
Copy link
Member

I've re-run my tests, and you're correct; MFFS-ing a cleared FPSCR into a reg set to zero does produce a NaN. I might have been thinking about a different instruction.

@Tilka
Copy link
Member Author

Tilka commented Aug 21, 2015

Haven't run into any problems.

Tilka added a commit that referenced this pull request Aug 21, 2015
Jit64: implement FPSCR related instructions
@Tilka Tilka merged commit 01aea96 into dolphin-emu:master Aug 21, 2015
@Tilka Tilka deleted the fpscr branch August 21, 2015 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants