Add stereoscopic options to tested gameini files

[SMarioMan]

Stereoscopy values have been tested and a convergence value of 26 is ideal for placing the characters on the convergence plane. No perceived issues with disabling monoscopic shadows.

[MayImilae]

Is it wise to be adding values like this before anyone has the OSVR hardware?

@Armada651

[SMarioMan]

This value already works great on 3D monitors and TVs. Unless I'm missing something, this value should still work just as well for VR.

[MayImilae]

Oh right, sorry, I'm too caught up in VR hype!

[CrossVR]

Thanks for your contribution, stereoscopy game settings are more than welcome.

However StereoEFBMonoDepth already defaults to False, so I don't think it's necessary in the INI file.

@MaJoRoesch VR won't make use of the convergence values, since those values are needed to simulate a window into a 3D world. When you put on a VR headset, there is no more window and the convergence value is (nearly) zero.

What we do need to pay attention to is separation values, those are dependent on world scale and that highly affects VR headsets with positional tracking. To prepare for VR I will likely change the separation values to be true IPD values so we can use any 3D stereoscopy separation optimizations for VR too.

[SMarioMan]

Thanks @Armada651. I updated the files to eliminate the StereoEFBMonoDepth parameter.

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• mario-tennis-menu on ogl-lin-nv: diff

_{^{automated-fifoci-reporter}}

[CrossVR]

By the way, currently the stereoscopy settings are designed so that the INI setting adds to the value set in the Graphics options. But I'm not entirely satisfied with it, since convergence is highly dependent on the game being played. I think as soon as we have enough INI settings I will remove the convergence option from Graphics and set the convergence entirely from the game settings.

I'll also see if I can make finding the convergence value a bit easier. If you have any suggestions please let me know.

[Dogway]

I made a convergence and depth list of the most popular Wii and GC games (about 60 titles). They all have different convergence and depth, although convergence below 20 is normal. They are all bound to the graphics setting so I don't know how the values would change were you to remove the setting from graphics and rely entirely on game properties.

[lioncash]

This could have used a rebase before merging, but ¯_(ツ)_/¯

[CrossVR]

@Eckso Well the values won't actually change, though I will add the default convergence value from the graphics options to the value stored in the INIs if I remove it. I'm just wondering what users think about the current system, where there are two settings controlling the convergence.

Currently it works like this: Actual Convergence = Minimum Convergence + Convergence Setting. It's convenient because it makes sure that opening the graphics options won't override the value stored in the INI, but it may be confusing and it's also prone to users ruining the 3D effect by configuring the convergence incorrectly.

[SMarioMan]

@Armada651 The values I found are ideal as an actual convergence value, rather than a minimum convergence, since it's easier to set the convergence setting to 0 than it is the default. As such, I think it makes sense to have a convergence setting that can be negative or positive for games that already have a default, in case people have different preferences. I don't know how that would best be implemented though.

[Dogway]

@Armada651: The intrinsic values "won't change", but the currently used values will need to be modified (subtracted) if you insist on adding a default value to the mix.

Convergence should be in only one place, if you want to get rid of it from the graphics options you need to make it as accessible as it was so an end user can adjust settings with visual feedback.

@SMarioMan: There's no "correct convergence", some people want everything within the TV space, some want things to pop out (ie. I configured DKCR to convergence 10 -foremost objects also within convergence plane-). I wouldn't touch anything at all, remove one of the options and make sure that the people that configured things correctly (like me) don't have to go through the hurdle again.

[SMarioMan]

@Eckso That's absolutely correct. It's generally best to set it so that the main point of interest is at the convergence point to avoid unnecessary eye strain and to "guide" the eyes to the appropriate subject. Things like UI and the main character usually fit that bill, but it's all a matter of preference, of course.
More than anything, I just got tired of switching between radically different values for each game, so I thought I'd share good settings here, so other people wouldn't have to mess too much with it.

[CrossVR]

@Eckso I don't want you to have to go over the hurdle again, I want to take the hurdle away. Because the current situation leaves many users that won't go over that hurdle with a bad experience. I'd like to know what kind of hurdles you're facing when using this feature and then we can find solutions for them.

The first step to give users a better experience is by providing some sensible defaults for every game, so you don't have to figure those out by yourself. These values won't be perfect for everyone, but at least the general experience will improve.

If you want to use another convergence setting you can do so from the Game Properties. The values you configure there won't be overridden by new default values added through these INIs.

@SMarioMan So you've configured the convergence values in your PRs assuming a convergence in the graphics options of 0? If so, I can definitely change the setting in the Graphics options to accept negative values with a default of 0 so the default can be offset in either direction, that would indeed make more sense.

I think I'll make that a percentile value, since the scale of the convergence value varies so widely. So you can configure it from 0% until 200% of the default value.

How do you currently find these convergence values? Is there anything I can change to make that procedure more convenient?

[Dogway]

@Armada651: The hurdle comes when you refactor the settings every time without a well founded reason and thus forces all the users that already set the values by themselves (which IMO is what everyone should be doing) to drop their personal convergence choice in favor of Dolphin's defaults, or go through all of them again. I have all convergence and depth settings already for most top Wii/GC games, I don't want a commit that breaks the work I (or anyone) have done, and I don't think it should be happening.

@SMarioMan: Depth (as opposed to pop out effect from convergence) doesn't cause any eye strain at all, it's like if in Mirror's Edge you set up the convergence plane 10 meter forward because that's where you are going to be staring most of the time, when the correct convergence plane should be as in reality where the character is placed (adjusted to legs or arms). Your current DKCR convergence value is as if you were playing with all the foremost graphics (ground, rocks, trees, bushes) popping out of the screen, or in other words it's like playing a game in 2D on TV with all sorts of objects obstructing your view merely a few centimeters away from the eyes, it's distracting. Pop out effect shouldn't a default effect, it's obstructive.

[CrossVR]

@Eckso Most users who enable 3D are looking for that pop-out effect, which is what 3D stereoscopy is advertised to do. But that may not be good for everyone, so that's why we make it customizable. If you don't like the new default you can easily override it from the game properties. Just set it to 0 there and after that any changes from Dolphin won't affect you.

I'll also implement the suggestion from @SMarioMan after which you can disable all convergence values with the setting in the graphics options. That should get rid of the hurdle you are referring to. Please just wait until you can test a PR with the new setting and then we can see if it works out for everyone.

[SMarioMan]

@Armada651 Yes, I configured them assuming a convergence in the graphics options of 0. A percentile value actually sounds really intuitive for known values.

I currently find the values by using anaglyph greyscale mode, maxing out the depth value to make convergence more easily noticeable, and adjusting the convergence graphics slider until the point of interest is grey. If it has any red and cyan along the edges, I know its popping in or out. Once I find what seems to be a proper value, I manually type in the sum of the graphics setting plus the minimum setting to make a new minimum in my gameini. The biggest problem I have finding the values is that the slider doesn't actually show me that values and has a more restricted range than the hard value in the gameini. Also, adjusting the gameini doesn't affect the game without a restart of the emulator. There are savestates, but it still took lots of restarts to increase the setting enough to find some values.