OGL: reimplement SSAA based on ARB_gpu_shader5 #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So i965 shall support it again.
|
Meh, i965 will support it. On mesa 10.6.6, it does look like http://markus.members.selfnet.de/dolphin/i965-ssaa.png |
|
Wait, I'm confused -- is that screenshot with or without this patch? And why does it look like the spaceship is covered in bugs? |
|
After this patch, and before #2986. In between, i965 doesn't support SSAA at all. I think it's a driver bug because of dual source blend + sample shading. But this bug is already fixed within mesa git. |
|
Code changes look OK to me, someone else must sign off on OpenGL logic changes though. |
Sonicadvance1
added a commit
that referenced
this pull request
Sep 12, 2015
OGL: reimplement SSAA based on ARB_gpu_shader5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So i965 shall support it again. GLSL 4.00 is a by far bigger requirement than ARB_gpu_shader5