New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoConfig: Change convergence setting to percentage value. #3017
Conversation
@SMarioMan Could you test the build of this PR? |
{ | ||
iStereoConvergencePercentage = (old_convergence * 100) / 20; | ||
enhancements->Set("StereoConvergencePercentage", iStereoConvergencePercentage); | ||
enhancements->Delete("StereoConvergence"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Yeah I still have to figure out how I want to do snapping at 100%. It's very strange that you have to add 30 ticks to the global slider, how did you initially find the convergence values? Using the global slider or the ticker in the game properties? |
@Armada651 When I first found the values, I used a combination of game properties and global slider to find the value. Then I summed them together (grabbing the specific values from the ini files) and put that value in the game properties section and turned the global slider all the way down. That worked prefectly for me. |
@SMarioMan The default value in the game properties was 20, correct? |
@Armada651 I honestly have no clue off the top of my head. The difficulty of setting it to such a specific value was why I set the game inis to assume a global value of 0 though. |
@SMarioMan Try adding a value of 20 to all convergence values and setting the convergence slider back to 100% (I'd just edit your Dolphin.ini for now). |
5558808
to
1940946
Compare
Ready for review, I dropped the upgrade code from this PR. Instead I suggest we cherry-pick at least this change to the stable so we don't get too many people using the previous method of setting the convergence value. |
For reference, this is what the new slider looks like: https://www.dropbox.com/s/ubj74862tf7syuv/Schermafdruk%202015-09-19%2016.38.01.png?dl=0 |
@Armada651 Changing the StereoConvergence value in Dolphin-x64\Sys\GameSettings\SF8.ini seems to do nothing for me in Donkey Kong Country Returns with the latest version of your PR. Still requires me to increment the slider by 30 ticks (70 ticks from the right). |
sounds fine to me, but needs a rebase. |
@degasus This PR is ready for review. |
VideoConfig: Change convergence setting to percentage value.
This PR seems to have completely broken the convergence values I've found. Neither StereoConvergenceMinimum nor StereoConvergence values seem to change anything for me when I adjust them in the default inis. |
@SMarioMan You are right, I think a line was dropped in my rebase. I'll file a new PR to fix this. EDIT: It was not lost in the rebase, it was just moved to the |
This makes more sense for people maintaining the convergence values in the game settings.