Common: Get rid of a few pointer casts #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tilka
added a commit
that referenced
this pull request
Sep 15, 2015
Common: Get rid of a few pointer casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubsan doesn't fire in our code during initialization of a clean GUI build of Dolphin with this, which is also nice (unfortunately we still get runtime notifications about wx, but we can't do anything about that, aside from submitting patches to wx).
It might be more beneficial/less icky to consider altering LinearDiskCache to store the ID string as a char array directly instead of a u32, however I've kept it like this to preserve functionality (if it's fine to change it to a char[5], I can amend this PR, or do a followup.)