Use correct GetTicksPerSecond() value in IPC delays #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant IPC_DEFAULT_DELAY used a value from GetTicksPerSecond(), which in turn uses a value from CPU_CORE_CLOCK... but CPU_CORE_CLOCK isn't actually a constant! It's first initialized to 486 MHz and then changed to 729 MHz in SystemTimers::PreInit if emulating a Wii. This means that the IPC delays always used 486 MHz and thus were wrong. To fix this, the IPC reply constants are changed to functions.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system: automated-fifoci-reporter |
|
LGTM. |
shuffle2
added a commit
that referenced
this pull request
Oct 4, 2015
Use correct GetTicksPerSecond() value in IPC delays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant IPC_DEFAULT_DELAY used a value from GetTicksPerSecond(), which in turn uses a value from CPU_CORE_CLOCK... but CPU_CORE_CLOCK isn't actually a constant! It's first initialized to 486 MHz and then changed to 729 MHz in SystemTimers::PreInit if emulating a Wii. This means that the IPC delays always used 486 MHz and thus were wrong. To fix this, the IPC reply constants are changed to functions.