Fix building with PCH disabled. #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the point was adding Common.h back to all of these...and that one string.h include looks off too. |
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| #include <atomic> | |||
| #include <mutex> | |||
| #include <string> | |||
| #include <string.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Many are likely replaceable with cstring or cstdlib, there are some files that rely on the __forceinline definition though. |
|
I included Common/Common.h mostly for _trans, UNUSED, and scm_rev_git_str. |
|
@dolphin-emu-bot rebuild |
1 similar comment
|
@dolphin-emu-bot rebuild |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system: automated-fifoci-reporter |
|
LGTM |
lioncash
added a commit
that referenced
this pull request
Oct 3, 2015
Fix building with PCH disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.