Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinWX: Improve HBC banner scaling #3111

Merged
merged 2 commits into from Dec 2, 2015

Conversation

@JosJuice
Copy link
Contributor

JosJuice commented Sep 30, 2015

Aspect ratios are now correct, and the scaling algorithm is better. The scaling still looks worse than in DolphinQt, but I don't know why. Maybe the quality of wxIMAGE_QUALITY_HIGH isn't especially high after all?

Needs testing with GC games when rendering at a 2x scale. I would also appreciate someone testing whether the white dots bug is fixed: https://bugs.dolphin-emu.org/issues/8899

The screenshot below can be compared to the ones in PRs #2958 (DolphinWX) and #2993 (DolphinQt).

JosJuice added 2 commits Sep 30, 2015
* Makes HBC icons look better
* Fixes the issue with white dots appearing in downscaled images
* No longer subjectively better for GC banners according to comex
@JosJuice JosJuice changed the title DolphinWX: Improve banner scaling DolphinWX: Improve HBC banner scaling Sep 30, 2015
@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Sep 30, 2015

Doesn't HBC format include the name in xml or something? we only show boot.dol? :(

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Sep 30, 2015

It does include the name in an XML file. DolphinQt handles it already, but not DolphinWX because we currently don't have a good way to parse XML there. The only thing I know about it is that Lioncash said that we don't have the wxXML module enabled.

@phire

This comment has been minimized.

Copy link
Member

phire commented Oct 28, 2015

Enabling the wxXML module is easy enough.

@degasus

This comment has been minimized.

Copy link
Member

degasus commented Dec 2, 2015

sounds like all comments does not apply to this PR at all. This is about banners, not about the text. So LGTM

degasus added a commit that referenced this pull request Dec 2, 2015
DolphinWX: Improve HBC banner scaling
@degasus degasus merged commit 4a40e7b into dolphin-emu:master Dec 2, 2015
11 checks passed
11 checks passed
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on the Buildbot.
Details
pr-android Build succeeded on the Buildbot.
Details
pr-deb-dbg-x64 Build succeeded on the Buildbot.
Details
pr-deb-x64 Build succeeded on the Buildbot.
Details
pr-freebsd Build succeeded on the Buildbot.
Details
pr-osx-x64 Build succeeded on the Buildbot.
Details
pr-ubu-nogui-x64 Build succeeded on the Buildbot.
Details
pr-ubu-x64 Build succeeded on the Buildbot.
Details
pr-win-dbg-x64 Build succeeded on the Buildbot.
Details
pr-win-x64 Build succeeded on the Buildbot.
Details
@JosJuice JosJuice deleted the JosJuice:wx-banner-scaling branch Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.