DolphinWX: Improve HBC banner scaling #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes HBC icons look better * Fixes the issue with white dots appearing in downscaled images * No longer subjectively better for GC banners according to comex
JosJuice
changed the title
|
Doesn't HBC format include the name in xml or something? we only show boot.dol? :( |
|
It does include the name in an XML file. DolphinQt handles it already, but not DolphinWX because we currently don't have a good way to parse XML there. The only thing I know about it is that Lioncash said that we don't have the wxXML module enabled. |
|
Enabling the wxXML module is easy enough. |
|
sounds like all comments does not apply to this PR at all. This is about banners, not about the text. So LGTM |
degasus
added a commit
that referenced
this pull request
Dec 2, 2015
DolphinWX: Improve HBC banner scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aspect ratios are now correct, and the scaling algorithm is better. The scaling still looks worse than in DolphinQt, but I don't know why. Maybe the quality of
wxIMAGE_QUALITY_HIGHisn't especially high after all?Needs testing with GC games when rendering at a 2x scale. I would also appreciate someone testing whether the white dots bug is fixed: https://bugs.dolphin-emu.org/issues/8899
The screenshot below can be compared to the ones in PRs #2958 (DolphinWX) and #2993 (DolphinQt).