Refactor logging code to get rid of a mutex. #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly so we can iterate over which LogListeners are enabled without having to aquire a lock.
| @@ -141,7 +136,9 @@ void LogManager::Log(LogTypes::LOG_LEVELS level, LogTypes::LOG_TYPE type, | |||
| #ifdef ANDROID | |||
| __android_log_write(ANDROID_LOG_INFO, "Dolphinemu", msg.c_str()); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
phire
force-pushed
the
remove-logging-lock
branch
from
5a44cb8
to
5f8a672
Compare
phire
force-pushed
the
remove-logging-lock
branch
from
e47b353
to
f84577b
Compare
| bool HasListeners() const { return !m_listeners.empty(); } | ||
| bool HasListeners() const { return bool(m_listener_ids); } | ||
|
|
||
| typedef class BitSet32::Iterator iterator; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
phire
added a commit
that referenced
this pull request
Dec 3, 2015
Refactor logging code to get rid of a mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't benchmarked it at all, but the code is cleaner.
Most of the individual log listeners lock additional mutexes anyway.