TextureCacheBase: Change CacheLinesPerRow to BytesPerRow #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| u32 blockW = TexDecoder_GetBlockWidthInTexels(format); | ||
| constexpr u32 TEXTURE_BLOCKS_PER_ROW = 32; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
lioncash
changed the title
|
|
||
| u32 numBlocksX = actualWidth / blockW; | ||
|
|
||
| // RGBA takes two cache lines per block; all others take one | ||
| if (format == GX_TF_RGBA8) | ||
| numBlocksX = numBlocksX * 2; | ||
| return numBlocksX; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
1 similar comment
|
LGTM |
|
Yeah. The buildbot's were why I didn't actually press merge. That function wants number of 32bit words per row. So bytesPerRow / sizeof(u32) |
|
@dolphin-emu-bot rebuild |
phire
added a commit
that referenced
this pull request
Oct 25, 2015
TextureCacheBase: Change CacheLinesPerRow to BytesPerRow
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.